Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade IRB and Reline to the latest release #952

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Upgrade IRB and Reline to the latest release #952

merged 1 commit into from
Aug 30, 2023

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Aug 30, 2023

The long-awaited irb:rdbg integration is finally out! Let's start testing them out 😁

@st0012 st0012 added this to the 2023-Q3 milestone Aug 30, 2023
@st0012 st0012 requested a review from a team as a code owner August 30, 2023 09:30
@st0012 st0012 requested a review from KaanOzkan August 30, 2023 09:30
@st0012 st0012 self-assigned this Aug 30, 2023
@st0012 st0012 requested a review from vinistock August 30, 2023 09:30
@github-actions
Copy link
Contributor 

Benchmark results in seconds (slowest at top)

          textDocument/completion average: 0.229239 std_dev: 0.006239
          textDocument/diagnostic average: 0.048942 std_dev: 0.012122
          textDocument/definition average: 0.005991 std_dev: 0.003398
      textDocument/selectionRange average: 0.005061 std_dev: 0.000726
   textDocument/documentHighlight average: 0.003322 std_dev: 0.000289
            textDocument/codeLens average: 0.003163 std_dev: 0.00026
        textDocument/documentLink average: 0.003049 std_dev: 0.000275
 textDocument/semanticTokens/full average: 0.002874 std_dev: 0.000281
      textDocument/documentSymbol average: 0.002868 std_dev: 0.000245
        textDocument/foldingRange average: 0.002787 std_dev: 0.000204
textDocument/semanticTokens/range average: 0.001887 std_dev: 0.000144
               codeAction/resolve average: 0.001856 std_dev: 0.000178
               textDocument/hover average: 0.001772 std_dev: 0.000205
           textDocument/inlayHint average: 0.001732 std_dev: 0.000176
    textDocument/onTypeFormatting average: 0.001062 std_dev: 0.000123
          textDocument/codeAction average: 0.001032 std_dev: 0.000115
          textDocument/formatting average: 0.001011 std_dev: 0.000334


================================================================================
Comparison with main branch:

 textDocument/semanticTokens/full faster by 11.297 %
textDocument/semanticTokens/range faster by 7.833 %
      textDocument/documentSymbol unchanged
        textDocument/foldingRange faster by 8.735 %
          textDocument/formatting unchanged
          textDocument/diagnostic unchanged
        textDocument/documentLink unchanged
           textDocument/inlayHint unchanged
      textDocument/selectionRange unchanged
   textDocument/documentHighlight unchanged
               textDocument/hover unchanged
          textDocument/codeAction unchanged
    textDocument/onTypeFormatting unchanged
               codeAction/resolve unchanged
          textDocument/completion unchanged
            textDocument/codeLens unchanged
          textDocument/definition unchanged


================================================================================
Missing benchmarks:

RubyLsp::Requests::ShowSyntaxTree

@st0012 st0012 merged commit 3e59910 into main Aug 30, 2023
31 checks passed
@st0012 st0012 deleted the upgrade-irb-reline branch August 30, 2023 20:54
andyw8 pushed a commit that referenced this pull request Sep 5, 2023
@st0012 @andyw8
Upgrade IRB and Reline to the latest release (#952)
2172433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

@Morriar Morriar Morriar approved these changes

@KaanOzkan KaanOzkan Awaiting requested review from KaanOzkan KaanOzkan was automatically assigned from Shopify/ruby-dev-exp

Assignees

@st0012 st0012

Labels
None yet
Projects
None yet
Milestone
2023-Q3
Development

Successfully merging this pull request may close these issues.
3 participants
@st0012 @Morriar @vinistock